Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, loosened up handling of
exclusivecommands such that downstream commands not marked asexclusiveare automatically treated as such. This is to avoid breakage of anyone who is currently defining anoverride def run() = Task.Command{ super.run()() }, which would otherwise start failing sincesuper.runhas suddenly becomeexclusive. Only downstream commands are treated as such - non-command tasks are still an error - and I expect this is an uncommon enough scenario that it won't affect muchAlso cleaned up the messiness in
BspRunModuleand tweakedbspRunto avoid theTask.Anonthat would interfere with exclusivityFix #5208